Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for permission_resource_format/permission_resource_matchi… #461

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

tomqwpl
Copy link
Contributor

@tomqwpl tomqwpl commented Jan 27, 2024

Fix for #460

@Nerzal
Copy link
Owner

Nerzal commented Feb 1, 2024

Hi, can you fix this linter warning?

Warning: var-naming: struct field PermissionResourceMatchingUri should be PermissionResourceMatchingURI (revive)

That would fix the golangci-lint step in the pipeline

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba0216d) 77.26% compared to head (698747a) 77.26%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files           4        4           
  Lines        2261     2261           
=======================================
  Hits         1747     1747           
  Misses        345      345           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@Nerzal Nerzal merged commit 56fa25b into Nerzal:main Feb 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants